Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,14 @@
<Generator>TextTemplatingFilePreprocessor</Generator>
<LastGenOutput>ExecutableAssembly.cs</LastGenOutput>
</None>
<None Update="Templates\AuthorizerSetupParameters.tt">
<Generator>TextTemplatingFilePreprocessor</Generator>
<LastGenOutput>AuthorizerSetupParameters.cs</LastGenOutput>
</None>
<None Update="Templates\AuthorizerInvoke.tt">
<Generator>TextTemplatingFilePreprocessor</Generator>
<LastGenOutput>AuthorizerInvoke.cs</LastGenOutput>
</None>
</ItemGroup>

<ItemGroup>
Expand Down Expand Up @@ -136,6 +144,16 @@
<AutoGen>True</AutoGen>
<DependentUpon>ExecutableAssembly.tt</DependentUpon>
</Compile>
<Compile Update="Templates\AuthorizerSetupParameters.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>AuthorizerSetupParameters.tt</DependentUpon>
</Compile>
<Compile Update="Templates\AuthorizerInvoke.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>AuthorizerInvoke.tt</DependentUpon>
</Compile>
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public static class DiagnosticDescriptors
title: "Authorizer Payload Version Mismatch",
messageFormat: "The authorizer '{0}' uses AuthorizerPayloadFormatVersion {1} but the endpoint uses HttpApiVersion {2}. This may cause unexpected behavior.",
category: "AWSLambdaCSharpGenerator",
DiagnosticSeverity.Warning,
DiagnosticSeverity.Error,
isEnabledByDefault: true);

public static readonly DiagnosticDescriptor MissingLambdaFunctionAttribute = new DiagnosticDescriptor(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static bool HasConvertibleParameter(this IList<ParameterModel> parameters
return parameters.Any(p =>
{
// All request types are forwarded to lambda method if specified, there is no parameter conversion required.
if (TypeFullNames.Requests.Contains(p.Type.FullName))
if (TypeFullNames.ApiGatewayRequests.Contains(p.Type.FullName))
{
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,24 @@ public static AttributeModel Build(AttributeData att, GeneratorExecutionContext
Type = TypeModelBuilder.Build(att.AttributeClass, context)
};
}
else if (att.AttributeClass.Equals(context.Compilation.GetTypeByMetadataName(TypeFullNames.HttpApiAuthorizerAttribute), SymbolEqualityComparer.Default))
{
var data = HttpApiAuthorizerAttributeBuilder.Build(att);
model = new AttributeModel<HttpApiAuthorizerAttribute>
{
Data = data,
Type = TypeModelBuilder.Build(att.AttributeClass, context)
};
}
else if (att.AttributeClass.Equals(context.Compilation.GetTypeByMetadataName(TypeFullNames.RestApiAuthorizerAttribute), SymbolEqualityComparer.Default))
{
var data = RestApiAuthorizerAttributeBuilder.Build(att);
model = new AttributeModel<RestApiAuthorizerAttribute>
{
Data = data,
Type = TypeModelBuilder.Build(att.AttributeClass, context)
};
}
else
{
model = new AttributeModel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public enum EventType
S3,
SQS,
DynamoDB,
Schedule
Schedule,
Authorizer
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ public static HashSet<EventType> Build(IMethodSymbol lambdaMethodSymbol,
{
events.Add(EventType.SQS);
}
else if (attribute.AttributeClass.ToDisplayString() == TypeFullNames.HttpApiAuthorizerAttribute
|| attribute.AttributeClass.ToDisplayString() == TypeFullNames.RestApiAuthorizerAttribute)
{
events.Add(EventType.Authorizer);
}
}

return events;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private static IList<string> BuildUsings(LambdaMethodModel lambdaMethodModel,

namespaces.Add("Amazon.Lambda.Core");

if(lambdaMethodModel.ReturnsIHttpResults)
if(lambdaMethodModel.ReturnsIHttpResults || lambdaMethodModel.ReturnsIAuthorizerResult)
{
namespaces.Add("Amazon.Lambda.Annotations.APIGateway");
}
Expand All @@ -79,6 +79,26 @@ private static TypeModel BuildResponseType(IMethodSymbol lambdaMethodSymbol,
return TypeModelBuilder.Build(typeStream, context);
}

// For authorizer functions returning IAuthorizerResult, the generated handler returns Stream
// (the IAuthorizerResult.Serialize method produces the JSON stream)
if (lambdaMethodModel.ReturnsIAuthorizerResult)
{
var typeStream = context.Compilation.GetTypeByMetadataName(TypeFullNames.Stream);
if (lambdaMethodModel.ReturnsGenericTask)
{
var genericTask = task.Construct(typeStream);
return TypeModelBuilder.Build(genericTask, context);
}
return TypeModelBuilder.Build(typeStream, context);
}

// For authorizer functions that return raw API Gateway types (backwards compatibility),
// pass through the return type as-is
if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.HttpApiAuthorizerAttribute) ||
lambdaMethodSymbol.HasAttribute(context, TypeFullNames.RestApiAuthorizerAttribute))
{
return lambdaMethodModel.ReturnType;
}

if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.RestApiAttribute))
{
Expand Down Expand Up @@ -143,6 +163,20 @@ private static HttpApiVersion GetHttpApiVersion(IMethodSymbol lambdaMethodSymbol
return (HttpApiVersion)versionArgument.Value;
}

private static AuthorizerPayloadFormatVersion GetAuthorizerPayloadFormatVersion(AttributeData authorizerAttribute)
{
var versionArg = authorizerAttribute.NamedArguments
.FirstOrDefault(arg => arg.Key == "AuthorizerPayloadFormatVersion").Value;

if (versionArg.Type == null || versionArg.Value == null)
{
// Default is V2
return AuthorizerPayloadFormatVersion.V2;
}

return (AuthorizerPayloadFormatVersion)(int)versionArg.Value;
}

private static IList<ParameterModel> BuildParameters(IMethodSymbol lambdaMethodSymbol,
LambdaMethodModel lambdaMethodModel, GeneratorExecutionContext context)
{
Expand All @@ -158,7 +192,48 @@ private static IList<ParameterModel> BuildParameters(IMethodSymbol lambdaMethodS
Documentation = "The ILambdaContext that provides methods for logging and describing the Lambda environment."
};

if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.RestApiAttribute))
if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.HttpApiAuthorizerAttribute))
{
// For HTTP API authorizer functions, the generated handler accepts the authorizer request type
var authorizerAttribute = lambdaMethodSymbol.GetAttributeData(context, TypeFullNames.HttpApiAuthorizerAttribute);
var payloadVersion = GetAuthorizerPayloadFormatVersion(authorizerAttribute);

string requestTypeName;
if (payloadVersion == AuthorizerPayloadFormatVersion.V2)
{
requestTypeName = TypeFullNames.APIGatewayCustomAuthorizerV2Request;
}
else
{
requestTypeName = TypeFullNames.APIGatewayCustomAuthorizerRequest;
}

var symbol = context.Compilation.GetTypeByMetadataName(requestTypeName);
var type = TypeModelBuilder.Build(symbol, context);
var requestParameter = new ParameterModel
{
Name = "__request__",
Type = type,
Documentation = "The API Gateway authorizer request object that will be processed by the Lambda function handler."
};
parameters.Add(requestParameter);
parameters.Add(contextParameter);
}
else if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.RestApiAuthorizerAttribute))
{
// For REST API authorizer functions, always use APIGatewayCustomAuthorizerRequest
var symbol = context.Compilation.GetTypeByMetadataName(TypeFullNames.APIGatewayCustomAuthorizerRequest);
var type = TypeModelBuilder.Build(symbol, context);
var requestParameter = new ParameterModel
{
Name = "__request__",
Type = type,
Documentation = "The API Gateway authorizer request object that will be processed by the Lambda function handler."
};
parameters.Add(requestParameter);
parameters.Add(contextParameter);
}
else if (lambdaMethodSymbol.HasAttribute(context, TypeFullNames.RestApiAttribute))
{
var symbol = context.Compilation.GetTypeByMetadataName(TypeFullNames.APIGatewayProxyRequest);
var type = TypeModelBuilder.Build(symbol, context);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,31 @@ public bool ReturnsIHttpResults
}
}

/// <summary>
/// Returns true if the Lambda function returns either IAuthorizerResult or Task&lt;IAuthorizerResult&gt;
/// </summary>
public bool ReturnsIAuthorizerResult
{
get
{
if (ReturnsVoid)
{
return false;
}

if (ReturnType.FullName == TypeFullNames.IAuthorizerResult)
{
return true;
}
if (ReturnsGenericTask && ReturnType.TypeArguments.Count == 1 && ReturnType.TypeArguments[0].FullName == TypeFullNames.IAuthorizerResult)
{
return true;
}

return false;
}
}

/// <summary>
/// Returns true if the Lambda function returns either void, Task, SQSBatchResponse or Task<SQSBatchResponse>
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public virtual string TransformText()
}

// Pass the same request parameter for Request Type that comes from the generated method.
if (TypeFullNames.Requests.Contains(p.Type.FullName))
if (TypeFullNames.ApiGatewayRequests.Contains(p.Type.FullName))
{
return "__request__";
}
Expand Down Expand Up @@ -83,7 +83,7 @@ public virtual string TransformText()

foreach (var parameter in _model.LambdaMethod.Parameters)
{
if (parameter.Type.FullName == TypeFullNames.ILambdaContext || TypeFullNames.Requests.Contains(parameter.Type.FullName))
if (parameter.Type.FullName == TypeFullNames.ILambdaContext || TypeFullNames.ApiGatewayRequests.Contains(parameter.Type.FullName))
{
// No action required for ILambdaContext and RequestType, they are passed from the generated method parameter directly to the original method.
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}

// Pass the same request parameter for Request Type that comes from the generated method.
if (TypeFullNames.Requests.Contains(p.Type.FullName))
if (TypeFullNames.ApiGatewayRequests.Contains(p.Type.FullName))
{
return "__request__";
}
Expand Down Expand Up @@ -52,7 +52,7 @@

foreach (var parameter in _model.LambdaMethod.Parameters)
{
if (parameter.Type.FullName == TypeFullNames.ILambdaContext || TypeFullNames.Requests.Contains(parameter.Type.FullName))
if (parameter.Type.FullName == TypeFullNames.ILambdaContext || TypeFullNames.ApiGatewayRequests.Contains(parameter.Type.FullName))
{
// No action required for ILambdaContext and RequestType, they are passed from the generated method parameter directly to the original method.
}
Expand Down
Loading
Loading