You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a well-scoped CI-only change. The workflow now calls the generic opentelemetry-orchestrator.yml (same pinned SHA 397d523d…) with the Python settings passed explicitly, and the python_sdk_ref → sdk_ref rename preserves the identical ${{ github.event.pull_request.head.sha || github.sha }} resolution for pull_request/push/workflow_dispatch. The updated contract test in .github/scripts/tests/test_opentelemetry_conformance_workflow.py is internally consistent with the proposed workflow: every asserted string is present, and the relaxation from "otlp_endpoint:" to "\n otlp_endpoint:" is required (the new collector_otlp_endpoint: input contains the old substring) while still guarding the deprecated bare input without false-positiving on collector_otlp_endpoint:. The test is wired into test-parser.yml, satisfying the repo's test requirement for a CI-config change.
Residual test risk: The contract test is purely a text-substring check — it does not validate that the external opentelemetry-orchestrator.yml at the pinned SHA actually declares the inputs now being passed (language, resource_prefix, sdk_repository, checkout_sdk, contract_test_command, adot_release_repository, collector_compatible_runtime, collector_otlp_endpoint, suite_timeout_minutes, and the retained phase/delay_seconds/aws_region). If the orchestrator's input contract differs, the caller would fail at dispatch time, and this in-repo test would not catch it. This is unverifiable from within this repository; confirming it requires checking the orchestrator definition in aws/aws-durable-execution-conformance-tests at that revision.
Reviewed commit 564b480ced50db37f543c313c63b798a8732e21e. Workflow run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest .github/scripts/tests/test_build_lambda_layer.py .github/scripts/tests/test_opentelemetry_conformance_workflow.py .github/scripts/tests/test_parse_sdk_branch.py -qgit diff --check