Conversation
Previously, context.py imported BatchResult from the types module, which only exposed the Protocol interface with the get_results() method. This prevented client-side type checkers and IDEs from discovering the full set of methods available on BatchResult objects returned by map() and parallel() operations. Changed to import the concrete BatchResult class from concurrency.models, which exposes all available methods including: - throw_if_error() - succeeded(), failed(), started() - has_failure, status properties - success_count, failure_count, started_count properties - get_errors() This improves developer experience by providing accurate type hints and autocomplete for all BatchResult methods without introducing circular dependencies.
yaythomas
force-pushed
the
batchresult-concrete
branch
from
c67e065 to
d9ff4e5
Compare
ParidelPooya
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, context.py imported BatchResult from the types module, which only exposed the Protocol interface with the get_results() method. This prevented client-side type checkers and IDEs from discovering the full set of methods available on BatchResult objects returned by map() and parallel() operations.
Changed to import the concrete BatchResult class from concurrency.models, which exposes all available methods including:
This improves developer experience by providing accurate type hints and autocomplete for all BatchResult methods without introducing circular dependencies.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.