fix: wait_for_condition attempt count #289
Merged
+130
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix off-by-one error in wait_for_condition attempt numbering where the sequence was 1, 1, 2, 3... instead of the correct 1, 2, 3, 4... The bug occurred because the code read step_details.attempt directly, which represents completed attempts, not the current attempt number. The current attempt should always be checkpointed_attempts + 1. Changes: - Update attempt calculation in wait_for_condition.py - Add explanatory comment about checkpoint semantics - Update test assertion to expect attempt=4 when checkpoint has 3 - Add comprehensive test for monotonic attempt sequence closes #288
Remove Logger's +1 transformation and have all code pass current attempt (1, 2, 3...) consistently throughout the codebase. Previously, Logger added +1 internally, creating confusion about whether code should pass 'current attempt' or 'checkpointed attempt'. This standardization removes the hidden transformation. Changes: - Remove +1 from Logger.from_log_info() (logger.py line 75) - Update StepContext to pass current attempt by adding +1 (step.py lines 205-208) - Update logger tests to expect current attempt values This ensures all components use the same convention: current attempt = checkpointed attempts + 1, with no hidden transformations.
bchampp
approved these changes
Feb 3, 2026
wangyb-A
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix off-by-one error in wait_for_condition attempt numbering where the sequence was 1, 1, 2, 3... instead of the correct 1, 2, 3, 4...
The bug occurred because the code read step_details.attempt directly, which represents completed attempts, not the current attempt number. The current attempt should always be checkpointed_attempts + 1.
Additionally, previously, Logger added +1 internally, creating confusion about whether
code should pass 'current attempt' or 'checkpointed attempt'. This
standardization removes the hidden transformation.
Changes:
closes #288
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.