Skip to content

ci: grant id-token: write for Slack notify workflow - #642

Merged
hln33 merged 1 commit into
mainfrom
fix/notify-id-token-permission
Aug 21, 2026
Merged

ci: grant id-token: write for Slack notify workflow#642
hln33 merged 1 commit into
mainfrom
fix/notify-id-token-permission

Conversation

@hln33

@hln33 hln33 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Fixes aws/aws-durable-execution-ci#30.

The reusable notify.yml in aws-durable-execution-ci changed its
summarize job at ac55d9f to assume BEDROCK_ROLE_ARN via OIDC,
requiring id-token: write. Consumer notify.yml files still grant
only contents: read + models: read, and GitHub caps a reusable
workflow's token at the caller's grant — aborting the run at startup
and dropping all Slack notifications.

Changes (identical across all four consumer repos):

  • Add id-token: write permission
  • Explicitly forward BEDROCK_ROLE_ARN (enables AI-generated summaries
    when the org secret is configured) alongside the existing Slack webhooks

@hln33
hln33 force-pushed the fix/notify-id-token-permission branch from b2a1834 to 6f71e10 Compare August 21, 2026 21:17
@hln33
hln33 temporarily deployed to ai-pr-review-runtime August 21, 2026 21:26 — with GitHub Actions Inactive
@hln33
hln33 temporarily deployed to ai-pr-review-runtime August 21, 2026 21:26 — with GitHub Actions Inactive
@hln33
hln33 merged commit 0c9d4ce into main Aug 21, 2026
8 checks passed
@hln33
hln33 deleted the fix/notify-id-token-permission branch August 21, 2026 21:29
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk is limited to runtime validation of the external reusable workflow and OIDC role configuration.

Reviewed commit 6f71e10708fe26cfc516a1914c987bdda6772868. Workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Claude AI review

This PR makes a minimal, CI-only change to .github/workflows/notify.yml: it adds id-token: write to the notify job's permissions block and forwards the BEDROCK_ROLE_ARN secret to the pinned reusable workflow. The change is correct and appropriately scoped:

  • id-token: write is declared at the job level, the correct place for a reusable-workflow (uses:) call, and resolves the described startup abort caused by GitHub capping the reusable workflow's token at the caller's grant.
  • The reusable workflow remains pinned to a full commit SHA (@ac55d9f...), matching the SHA in the PR description — good supply-chain hygiene.
  • The top-level permissions: {} default-deny is preserved, so the added id-token: write scope stays confined to this single job.
  • YAML indentation of both added lines is consistent with surrounding entries.

No Java/SDK source, tests, checkpoint-replay, serialization, or lifecycle code is affected, so the repository's unit/integration/replay test requirements do not apply here.

Findings: None.

Residual risk: Functional success still depends on the BEDROCK_ROLE_ARN org secret being configured and on the referenced reusable workflow at ac55d9f correctly consuming that secret and id-token: write — neither is verifiable from this repository. Behavior is unchanged when the secret is unset (empty value forwarded), consistent with the PR's stated intent.

Reviewed commit 6f71e10708fe26cfc516a1914c987bdda6772868. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Slack notification workflow

2 participants