fix(sdk): Deprecate StepConfig.semantics, add StepConfig.semanticsPerRetry with correct AT_MOST_ONCE behaviour#429
Merged
Merged
Conversation
zhongkechen
previously approved these changes
Jun 5, 2026
zhongkechen
reviewed
Jun 5, 2026
…Retry with correct AT_MOST_ONCE behaviour
zhongkechen
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#394
Description
Steps configured with
StepSemantics.AT_MOST_ONCE_PER_RETRYcurrently have incorrect behaviour. They are not retrying in the case of failures without a checkpoint.This PR adds the correct
AT_MOST_ONCE_PER_RETRYbehaviour as part of a new enum (StepSemanticsPerRetry) in order to prevent a breaking change to users of the currentStepSemantics.AT_MOST_ONCE_PER_RETRY.StepSemanticsPerRetry.AT_MOST_ONCE_PER_RETRYto get the correctAT_MOST_ONCE_PER_RETRYbehaviour.StepSemanticswith incorrectAT_MOST_ONCE_PER_RETRYbehaviour is still available.StepSemanticsPerRetryis null by default. So there will be no behaviour changes for users that haven't specifiedStepSemanticsPerRetry.StepSemanticsis being marked as deprecated, and will be fully removed in the next version update.Code Changes
StepSemanticsPerRetry.java.StepSemantics.javahas been marked as deprecated.StepConfig.javaStepSemanticsPerRetryfield/accessor/build.StepSemanticsmethods.StepOperation.javaStepSemanticsPerRetry.StepInterruptedExceptiononly whenStepSemanticsPerRetry == AT_MOST_ONCE_PER_RETRY.StepSemanticsIntegrationTest.javaStepSemanticsPerRetry.StepSemantics.AT_MOST_ONCE_PER_RETRYtest to make clear that it is accepting incorrect behaviour, and this behaviour is being kept for backwards compatability.StepConfigTest.javaadded tests forStepSemanticsPerRetry.Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? YES
Integration Tests
Have integration tests been written for these changes? YES
Examples
Has a new example been added for the change? (if applicable) N/A