-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Update EMR subcommand doc examples (applicable to v2 only) #9820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
aws-cli v2 introduced a change to how timestamps are returned in `aws emr` subcommands. Previously, a Unix time decimal was returned. Now, timestamps are returned with an ISO 8601 datetime string. This change is applicable only to aws-cli v2 docs.
aemous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the submission.
Looks good overall, I requested a couple minor changes.
| @@ -0,0 +1,20 @@ | |||
| **To list EMR Studios in the current region** | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description for this example, that follows the Style Guide for Descriptions.
See https://aws.github.io/aws-cli/docs_styleguide.html#description for details.
| @@ -0,0 +1,20 @@ | |||
| **To list EMR Studios in the current region** | |||
|
|
|||
| Command:: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment. Replace "Command::" with the description.
| } | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a For more information link to this example, as specified in the Style Guide.
See https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link for details.
Issue #, if available: None
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.