Fix non-deterministic zip output in cloudformation package#10421
Open
MsrOhkwr wants to merge 1 commit into
Open
Fix non-deterministic zip output in cloudformation package#10421MsrOhkwr wants to merge 1 commit into
MsrOhkwr wants to merge 1 commit into
Conversation
The make_zip function uses os.walk() to enumerate files, but the iteration order of directories and files is not guaranteed by the filesystem (depends on readdir() implementation). On Linux/ext4, this causes the zip entry order to vary between runs, producing different MD5 checksums for identical content. Sort directories and files during traversal to ensure deterministic zip output regardless of filesystem behavior.
MsrOhkwr
force-pushed
the
fix/make-zip-deterministic
branch
from
6574f23 to
1a72be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
make_zipinartifact_exporter.pyusesos.walk()without sorting, causing non-deterministic zip entry ordering. On Linux (ext4),readdir()returns entries in inode hash order, which varies when files are created in parallel (e.g., bynpm ci). This results in different MD5 checksums (and thus different S3 keys) foraws cloudformation packageacross runs, even when directory contents are identical.This change adds
dirs.sort()andsorted(files)to ensure deterministic zip output regardless of filesystem behavior.Reproduction: On CodeBuild (amazonlinux2-x86_64-standard:5.0, ext4), running
aws cloudformation packagetwice against the same directory afternpm ciproduces different S3 keys. With this fix, repeated runs produce the same key.Description of tests:
test_make_zip_deterministic_orderto verify entries are written in sorted orderBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.