sort files in cloudformation package when creating zip for consistency #10122
Open
tef-ger-florian-juettner wants to merge 1 commit intoaws:developfrom
Open
Conversation
… ordering across different os/filesystems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort files when zipping in cloudformation package
This change updates the
make_zipfunction inartifact_exporter.pyto sortdirectories and files before adding them to the ZIP archive.
make_ziprelies on `os.walk() for file collection, and its iteration orderdepends on the underlying filesystem. Since the package's S3 key is derived
from the hash of the final ZIP file, sorting the inputs increases determinism
when the source content is identical and helps avoid unnecessary deployments.
Note: This change affects only file ordering. Other ZIP metadata like mtime and
file permissions are still be controlled externally by the user before invoking
the package command. This keeps the change minimal and non-intrusive while
still giving users additional control over determinism when needed.
Partially addresses #3131.