generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 74
fix(cloudformation-diff): show PermissionSet as principal in IAM statement changes #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Jan 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 72 72
Lines 10087 10087
Branches 1330 1330
=======================================
Hits 8849 8849
Misses 1213 1213
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an AWS::SSO::PermissionSet contains an inline policy, cdk diff renders IAM Statement Changes with an empty Principal column. This makes the diff difficult to interpret, especially when multiple Permission Sets exist in the same stack, because the IAM Statement table does not indicate which Permission Set the statement belongs to.
This issue is reported in #956.
Solution
This PR introduces a minimal and targeted enhancement to the diff engine:
When the inline policy comes from an AWS::SSO::PermissionSet, and the derived principal would otherwise be empty:
The diff engine now assigns a pseudo-principal:
AWS:${<LogicalId>}This keeps the diff output consistent and readable, letting developers immediately see which Permission Set owns each IAM statement.
All existing behavior for IAM Roles, Users, Policies, Groups, and non-PermissionSet resources is unchanged.
Implementation Details
-> Parses inline statements,
-> Applies defaultResource (existing behavior),
-> Applies defaultPrincipal with a PermissionSet-specific pseudo-principal.
Tests
Updated PermissionSet-related expectations in
test/iam/detect-changes.test.tsto reflect the new principal.All IAM change detection tests now validate the presence of the pseudo-principal.
Full test suite executed successfully:
This change affects only the human-readable diff output.
Full test suite executed successfully:
Test Output (All Green)
All suites and tests passed locally after the PermissionSet principal enhancement:

Here is the full output of yarn test from my local environment:
Fixes #956
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license