Skip to content

feat(cloud-assembly-schema): validation report includes suppressed rules#1556

Open
kaizencc wants to merge 1 commit into
mainfrom
conroyka/suppressed-violations
Open

feat(cloud-assembly-schema): validation report includes suppressed rules#1556
kaizencc wants to merge 1 commit into
mainfrom
conroyka/suppressed-violations

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented May 26, 2026

Add suppressedViolations to PluginReportJson so acknowledged violations are retained in the report for audit purposes.

SuppressedViolationJson extends PolicyViolationJson with acknowledgedId (required), reason, and acknowledgedAt.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc deployed to automation May 26, 2026 18:21 — with GitHub Actions Active
@github-actions github-actions Bot added the p2 label May 26, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team May 26, 2026 18:21
@kaizencc kaizencc deployed to no-approval May 26, 2026 18:21 — with GitHub Actions Active
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@kaizencc kaizencc deployed to run-tests May 26, 2026 18:26 — with GitHub Actions Active
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (76445b3) to head (c8c1cda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files          76       76           
  Lines       10841    10841           
  Branches     1493     1493           
=======================================
  Hits         9560     9560           
  Misses       1253     1253           
  Partials       28       28           
Flag Coverage Δ
suite.unit 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants