Skip to content

chore: fix broken integ tests after yarn berry migration#1343

Draft
mrgrain wants to merge 1 commit intomainfrom
mrgrain/fix/integ/yarn-lockfile-after-version-bump
Draft

chore: fix broken integ tests after yarn berry migration#1343
mrgrain wants to merge 1 commit intomainfrom
mrgrain/fix/integ/yarn-lockfile-after-version-bump

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Apr 10, 2026

Since the Yarn Berry migration, the integ test workflow fails during the build step because the version bump changes workspace package versions, which invalidates the yarn.lock file. The initial yarn install --immutable correctly ensures a clean lockfile on checkout, but after yarn projen run bump modifies the workspace versions, the lockfile is now out of date and subsequent operations fail.

This adds a yarn install --immutable-cache step between the bump and build steps. The --immutable-cache flag allows the lockfile to be rewritten to reflect the new workspace resolutions, while still preventing any new packages from being downloaded from the npm registry. This gives us the safety guarantee we want (no surprise dependency changes) while accommodating the version bump.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add `yarn install --immutable-cache` after the version bump step.
The bump changes workspace package versions, which requires the
lockfile to be updated. Using `--immutable-cache` allows the
lockfile to update while preventing new packages from being
fetched from the registry.
@mrgrain mrgrain deployed to automation April 10, 2026 18:15 — with GitHub Actions Active
@mrgrain mrgrain deployed to no-approval April 10, 2026 18:16 — with GitHub Actions Active
@aws-cdk-automation aws-cdk-automation requested a review from a team April 10, 2026 18:16
@github-actions github-actions bot added the p2 label Apr 10, 2026
@mrgrain mrgrain changed the title fix(integ): yarn lockfile out of date after version bump chore: integ tests broken due to yarn lockfile out of date after version bump Apr 10, 2026
@mrgrain mrgrain changed the title chore: integ tests broken due to yarn lockfile out of date after version bump chore: fix broken integ tests after yarn berry migration Apr 10, 2026
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Apr 10, 2026
@mrgrain mrgrain deployed to run-tests April 10, 2026 18:20 — with GitHub Actions Active
@mrgrain mrgrain closed this Apr 10, 2026
auto-merge was automatically disabled April 10, 2026 18:20

Pull request was closed

@mrgrain mrgrain reopened this Apr 10, 2026
@mrgrain mrgrain marked this pull request as draft April 10, 2026 18:20
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.31%. Comparing base (841b47e) to head (a31280a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1343   +/-   ##
=======================================
  Coverage   88.30%   88.31%           
=======================================
  Files          73       73           
  Lines       10386    10386           
  Branches     1412     1414    +2     
=======================================
+ Hits         9171     9172    +1     
+ Misses       1188     1187    -1     
  Partials       27       27           
Flag Coverage Δ
suite.unit 88.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants