chore: refactor read write splitting plugins to use an abstract rw plugin#1229
Open
chore: refactor read write splitting plugins to use an abstract rw plugin#1229
Conversation
sophia-bq
approved these changes
May 4, 2026
| driver_dialect = self._plugin_service.driver_dialect | ||
|
|
||
| if close_only_if_idle and internal_conn == current_conn: | ||
| # Connection is in use, do not close |
Contributor
There was a problem hiding this comment.
Is there a reason we are removing the comments?
Contributor
Author
There was a problem hiding this comment.
Accidentally removed when removing debugging logs. Added them back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.