Conversation
karenc-bq
force-pushed
the
fix/handle-missing-cextension
branch
from
0ea34f6 to
ac20df5
Compare
sophia-bq
reviewed
Nov 12, 2025
| from mysql.connector.cursor_cext import CMySQLCursor | ||
|
|
||
| try: | ||
| from mysql.connector import CMySQLConnection |
Contributor
There was a problem hiding this comment.
I believe these are also imported in the tests/unit/test_mysql_driver_dialect.py file and tests/unit/test_mysql_driver_dialect.py file and tests/integration/container/test_blue_green_deployment.py - should those also be updated?
Contributor
Author
There was a problem hiding this comment.
unit tests are updated in a separate PR #1030 so I am intentionally leaving them out here. I will update the integration test though, good catch
sophia-bq
approved these changes
Nov 13, 2025
karenc-bq
force-pushed
the
fix/handle-missing-cextension
branch
from
cd2457c to
bb028f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The MySQLDriverDialect imports some classes there are only available if MySQL Connector/Python C Extension is available in the community driver. This is not necessarily always present on the customer's environment. In this case, the current behaviour would propagate an import error immediately and making the driver unusable.
This PR handles the case when C extension isn't available so it doesn't break customer's workflow.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.