Fix 6 bugs in introductory-blog-sagemaker-core.ipynb#4876
Open
vikeshpandey wants to merge 3 commits intoaws:defaultfrom
Open
Fix 6 bugs in introductory-blog-sagemaker-core.ipynb#4876vikeshpandey wants to merge 3 commits intoaws:defaultfrom
vikeshpandey wants to merge 3 commits intoaws:defaultfrom
Conversation
- Remove incomplete `s3_client =` assignment (unused variable) - Add missing `Endpoint.create()` cell before wait_for_status - Add missing `import boto3` before boto3.client usage - Fix S3 key path: output/train/test.csv -> output/test/test.csv - Fix endpoint response access: res["Body"] -> res.body (sagemaker-core SDK) - Define missing print_performance_metrics() function Fixes aws#4872
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 bugs reported in #4872 for
sagemaker-core/introductory-blog-sagemaker-core/introductory-blog-sagemaker-core.ipynb:s3_client =assignment (unused, caused confusion)Endpoint.create()cell —sagemaker_endpointwas referenced but never assignedimport boto3beforeboto3.client("s3")usageoutput/train/test.csv→output/test/test.csvres["Body"]→res.body(sagemaker-core SDK returns an object, not a dict)print_performance_metrics()functionCloses #4872