Support span event when application_signals is enabled#1982
Open
Support span event when application_signals is enabled#1982
Conversation
vastin
force-pushed
the
otlp-span-event
branch
from
35d1708 to
4f5d143
Compare
vastin
force-pushed
the
otlp-span-event
branch
from
3007280 to
98cee61
Compare
Contributor
|
This PR was marked stale due to lack of activity. |
Contributor
|
This PR was marked stale due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The OTLP span events will be dropped when translating OTLP span format into X-Ray trace format.
Description of changes
This PR will turn on
transit_spans_in_otlp_formatflag to preserve OTLP span format for Application Signals.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Tested local build of cwagent locally on EC2 and checked span events in Transaction Search console.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.