ci: declare permissions on build-check and codeql-analysis#694
Open
arpitjain099 wants to merge 2 commits into
Open
ci: declare permissions on build-check and codeql-analysis#694arpitjain099 wants to merge 2 commits into
arpitjain099 wants to merge 2 commits into
Conversation
build-check.yml: pure CI matrix compile - contents: read. codeql-analysis.yml: github/codeql-action workflows need actions: read contents: read security-events: write (SARIF upload) which is the standard scope set for any CodeQL workflow. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
7712a15 to
0952d5a
Compare
Author
|
Hi @sky333999, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Author
|
Gentle nudge in case this got buried. Let me know if there's anything I can help move forward. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflows currently inherit the repo default token scope:
build-check.yml— PR-time compile matrix (ubuntu/windows).contents: readcovers checkout.codeql-analysis.yml— runsgithub/codeql-action, which posts SARIF results back via the GitHub API. Standard CodeQL scopes:actions: read,contents: read,security-events: write.