feat: centralize Harness PR review workflow - #2
Open
aidandaly24 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
["main"]as the defaultWhy
Harness review mechanics are currently duplicated across
agentcore-cli,private-agentcore-cli-staging, andagent-inspector. Those copies havealready drifted, and their baked GitHub API credentials can complete a review
without successfully publishing it.
The shared workflow keeps the short-lived GitHub App token on the Actions
runner, passes only review context to Harness, requires a delimited final
review, and fails if GitHub rejects publication.
The Security reusable currently hardcodes
main, which prevents theagentcore-climigration branch from opting into review even when its callertrigger includes
refactor.Verification
python -m unittest test_harness_review.pypython -m py_compile harness_review.py test_harness_review.pygit diff --checkThe Harness action is pinned by the reusable workflow to commit
20441d03ec1be9944a2958be6b1264cda49a1772.