Skip to content

fix(tui): preserve picker selection after detail views - #1977

Closed
aidandaly24 wants to merge 4 commits into
refactorfrom
feat/memory-tui-context-actions
Closed

fix(tui): preserve picker selection after detail views#1977
aidandaly24 wants to merge 4 commits into
refactorfrom
feat/memory-tui-context-actions

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve the selected row when any PaginatedTablePicker opens a detail screen and the user returns with Escape
  • store the selected row's stable value in that list's history entry and restore it when the picker remounts
  • keep the behavior inside the shared picker instead of adding resource-specific navigation state
  • retain existing pagination, resize, transition, and filtering reset behavior

Fixes #1976

Testing

  • shared Harness list/detail regression for restoring the third selected row
  • Memory Event list/JSON regression for restoring the third selected Event
  • bun test src/components/PaginatedTablePicker.test.tsx src/components/ui/data-table/DataTable.test.tsx src/handlers/memory (92 pass)
  • bun test --coverage --coverage-reporter=lcov
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • TUI harness at 100x28, independently confirming third-row restoration in both Memory Event and Harness list flows

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 11, 2026
@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (531d068) to head (c57c589).
⚠️ Report is 7 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #1977   +/-   ##
=========================================
  Coverage     96.78%   96.78%           
=========================================
  Files           326      326           
  Lines         18061    18091   +30     
=========================================
+ Hits          17480    17510   +30     
  Misses          581      581           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 11, 2026
@aidandaly24
aidandaly24 force-pushed the feat/memory-tui-context-actions branch from dcd613f to e05690e Compare August 12, 2026 01:51
@aidandaly24 aidandaly24 changed the title feat(memory): add contextual events action feat(memory): polish contextual TUI actions Aug 12, 2026
@aidandaly24 aidandaly24 changed the title feat(memory): polish contextual TUI actions feat(memory): prioritize event browsing in TUI details Aug 12, 2026
jariy17
jariy17 previously approved these changes Aug 13, 2026

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but how is having events the first item a better customer experience.

@aidandaly24 aidandaly24 reopened this Aug 13, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 13, 2026
@aidandaly24
aidandaly24 marked this pull request as draft August 13, 2026 16:27
@aidandaly24 aidandaly24 changed the title feat(memory): prioritize event browsing in TUI details fix(tui): preserve picker selection after detail views Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants