Skip to content

feat(dev): add container dev runner - #1962

Merged
tejaskash merged 3 commits into
refactorfrom
feat/container-dev-runner
Aug 13, 2026
Merged

feat(dev): add container dev runner#1962
tejaskash merged 3 commits into
refactorfrom
feat/container-dev-runner

Conversation

@tejaskash

Copy link
Copy Markdown
Contributor

Summary

  • add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
  • validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
  • keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
  • cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

Verification

  • bun test (1013 tests)
  • bun test src/core/dev/ (30 tests)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build

@github-actions github-actions Bot added the size/l PR size: L label Aug 10, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch from 961beaf to e42dbf8 Compare August 10, 2026 18:41
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines Patch % Lines
src/io/exec.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1962      +/-   ##
============================================
+ Coverage     96.78%   96.81%   +0.03%     
============================================
  Files           326      327       +1     
  Lines         18061    18231     +170     
============================================
+ Hits          17480    17650     +170     
  Misses          581      581              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch from e42dbf8 to 853e311 Compare August 10, 2026 20:12
@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch 2 times, most recently from 3f4e482 to 5caac75 Compare August 10, 2026 20:25
@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch from 5caac75 to 10cea59 Compare August 10, 2026 20:57
Base automatically changed from feat/dev-server-core to refactor August 10, 2026 22:55
@jariy17
jariy17 force-pushed the feat/container-dev-runner branch from 10cea59 to c6dd19b Compare August 10, 2026 22:55
@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch 2 times, most recently from cb1915e to 69d7548 Compare August 11, 2026 16:24
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts
Comment thread src/core/dev/container.ts
Comment thread src/core/dev/container.ts
Comment thread src/core/dev/container.test.ts
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts
@tejaskash
tejaskash force-pushed the feat/container-dev-runner branch from 838f84f to 113dcde Compare August 12, 2026 13:41

@aidandaly24 aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit that could be fixed another time otherwise this lgtm:

Comment thread src/core/dev/container.ts
Comment thread src/io/exec.ts
@tejaskash
tejaskash requested review from notgitika and removed request for notgitika August 13, 2026 13:41
@tejaskash
tejaskash merged commit 2d6e44e into refactor Aug 13, 2026
16 checks passed
@tejaskash
tejaskash deleted the feat/container-dev-runner branch August 13, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/l PR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants