-
Notifications
You must be signed in to change notification settings - Fork 52
feat: add support for TS memory #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6986fb5
feat: add support for TS memory
nborges-aws 08b4403
fix: update snapshots and minor bug fixes
nborges-aws 0b0f763
fix: hide STM for TS strands path
nborges-aws 3da448b
fix: append actor id header when valid memory strategy selected
nborges-aws File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/assets/typescript/http/strands/capabilities/memory/memory.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { randomUUID } from 'node:crypto'; | ||
| import { MemoryManager } from '@strands-agents/sdk'; | ||
| import { createAgentCoreMemoryStores } from 'bedrock-agentcore/experimental/memory/strands'; | ||
|
|
||
| const MEMORY_ID = process.env.{{memoryProviders.[0].envVarName}}; | ||
|
|
||
| const CUSTOM_ACTOR_ID_HEADER = 'x-amzn-bedrock-agentcore-runtime-custom-actor-id'; | ||
|
|
||
| export function getActorId(payload: any, context: any): string { | ||
| const raw = | ||
| context?.headers?.[CUSTOM_ACTOR_ID_HEADER] || | ||
| payload?.userId || | ||
| context?.sessionId; | ||
| return typeof raw === 'string' && raw.trim().length > 0 ? raw.trim() : randomUUID(); | ||
| } | ||
|
|
||
| const memoryManagerCache = new Map<string, MemoryManager>(); | ||
|
|
||
| export function getOrCreateMemoryManager(sessionId: string, actorId: string): MemoryManager | null { | ||
| if (!MEMORY_ID) return null; | ||
|
|
||
| const key = `${actorId}:${sessionId}`; | ||
| let manager = memoryManagerCache.get(key); | ||
| if (manager) return manager; | ||
|
|
||
| const stores = createAgentCoreMemoryStores({ | ||
| memoryId: MEMORY_ID, | ||
| actorId, | ||
| sessionId, | ||
| namespaces: [ | ||
| {{#if (includes memoryProviders.[0].strategies "SEMANTIC")}} | ||
| { namespace: '/users/{actorId}/facts' }, | ||
| {{/if}} | ||
| {{#if (includes memoryProviders.[0].strategies "USER_PREFERENCE")}} | ||
| { namespace: '/users/{actorId}/preferences' }, | ||
| {{/if}} | ||
| {{#if (includes memoryProviders.[0].strategies "EPISODIC")}} | ||
| { namespace: '/episodes/{actorId}/{sessionId}' }, | ||
| {{/if}} | ||
| {{#if (includes memoryProviders.[0].strategies "SUMMARIZATION")}} | ||
| { namespace: '/summaries/{actorId}/{sessionId}' }, | ||
| {{/if}} | ||
| ], | ||
| // readMode defaults to 'per-namespace' (one retrieve call per namespace). | ||
| // Switch to 'subtree' to consolidate to a single hierarchical recall call. | ||
| extraction: true, | ||
| }); | ||
|
|
||
| manager = new MemoryManager({ stores }); | ||
| memoryManagerCache.set(key, manager); | ||
| return manager; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bedrock-agentcore@^0.3.0is not on npm yet (latest published is 0.2.4), and the importbedrock-agentcore/experimental/memory/strandsused inmemory.tsships in that unreleased version. Until 0.3.x is published, every newly generated TS Strands project (memory or not) will failnpm install. Per the PR description this PR shouldn't merge until the SDK is released — when it is, please also pin exact versions (drop the carets on bothbedrock-agentcoreand@strands-agents/sdk) per the note in the PR description.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be updated in PR once new SDK version is released.