test(unit): fix cross_account pollution + standardize unit-test setup#12
Merged
Conversation
test_lambda_runtime_tool.py replaced shared.cross_account in sys.modules at module scope and never restored it, breaking all of test_cross_account.py in a full `make test-unit` run. Replace with a scoped `cross_account_stub` fixture (monkeypatch.setitem, auto-restored). Also standardize the unit suite so this class of drift is less likely: - add tests/unit/conftest.py: centralizes deterministic AWS test env (region + dummy creds at import time) and auto-applies the `unit` marker to the whole package, so `pytest -m unit` selects all of it. - drop now-redundant per-file AWS_REGION setdefaults + the lone pytestmark. - docs/development.md: add a "Testing Conventions" section codifying handler loading, the no-global-sys.modules-stub rule, env handling, moto-vs-MagicMock, and markers. 488 unit+topology tests pass.
chanshih
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sys.modules pollution introduced in PR #9: test_lambda_runtime_tool.py replaced shared.cross_account in sys.modules at module scope and never restored it, breaking all of test_cross_account.py in a full
make test-unitrun.cross_account_stubfixture (monkeypatch.setitem, auto-restored).unitmarker to the whole package, so
pytest -m unitselects all of it.488 unit + topology tests pass.