chore(tests): prevent sentinel key collision in data-masking property test#5392
Open
svozza wants to merge 2 commits into
Open
chore(tests): prevent sentinel key collision in data-masking property test#5392svozza wants to merge 2 commits into
svozza wants to merge 2 commits into
Conversation
powertools-for-aws-oss-automation
Bot
added
size/XS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky property test in the data-masking package, plus two latent instances of the same defect. The tests use hardcoded sentinel keys (
id,keep) to assert that sibling fields survive masking, but the generated target field name could collide with the sentinel, collapsing both into one key. The masker then correctly masked it, and the assertion comparing against the sentinel failed. The erase utility itself behaves correctly; only the test generators were at fault.The
idcollision surfaced in an unrelated CI run (counterexample["a", "id", [""]]); the twokeepcollisions were found by auditing the remaining property tests for the same pattern.Changes
[*] skips array elements missing the targeted fieldtest to exclude"id", so it can never collide with the sentinel key"keep"sentinel in theparent.*.childandparent[*].childtests, which had the identical latent collisionIssue number: closes #5391
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.