chore(event_handler): refactoring http methods to reduce code#8123
chore(event_handler): refactoring http methods to reduce code#8123leandrodamascena wants to merge 2 commits intodevelopfrom
Conversation
powertools-for-aws-oss-automation
bot
added
the
size/L
powertools-for-aws-oss-automation
bot
added
size/L
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8123 +/- ##
========================================
Coverage 96.63% 96.63%
========================================
Files 284 284
Lines 14105 14105
Branches 1162 1162
========================================
Hits 13630 13630
Misses 345 345
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| get = _create_http_method.__func__("GET") # type: ignore[attr-defined] | ||
| post = _create_http_method.__func__("POST") # type: ignore[attr-defined] | ||
| put = _create_http_method.__func__("PUT") # type: ignore[attr-defined] | ||
| delete = _create_http_method.__func__("DELETE") # type: ignore[attr-defined] | ||
| patch = _create_http_method.__func__("PATCH") # type: ignore[attr-defined] | ||
| head = _create_http_method.__func__("HEAD") # type: ignore[attr-defined] |
There was a problem hiding this comment.
The issue mentions
Preserve type hints and docstrings for IDE support
Does this still work here despite the type: ignore?
There was a problem hiding this comment.
Hey @phipag thanks for the review. The autocomplete works in some IDE, but it depends on the strict level checking. Thanks a lot for catching this, I think we should not merge this and confuse customers with the Developer Experience.
Thanks a lot
|
Closing as not possible to merge. |
2 participants
Issue number: closes #8119
Summary
Refactor event handler http methods.
Changes
User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.