GetSamplingTargets statistics fixes and optimizations#1274
Merged
majanjua-amzn merged 2 commits intomainfrom Jan 13, 2026
Merged
GetSamplingTargets statistics fixes and optimizations#1274majanjua-amzn merged 2 commits intomainfrom
majanjua-amzn merged 2 commits intomainfrom
Conversation
majanjua-amzn
added
enhancement
majanjua-amzn
force-pushed
the
gst-improvements
branch
from
94188db to
c5c6ae0
Compare
AsakerMohd
approved these changes
Jan 7, 2026
wangzlei
approved these changes
Jan 12, 2026
majanjua-amzn
added a commit
that referenced
this pull request
Jan 15, 2026
This reverts commit 7f1beb8.
majanjua-amzn
added a commit
that referenced
this pull request
Jan 16, 2026
X-Ray service is currently unable to receive empty statistics documents, and we are currently investigating the response pattern to fix this. In the meantime, we will revert the changes in this PR. Reverts #1274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Changes
matchedRuleis not overwritten after it has already been set to a higher priority ruleCallout
Technically, not calling GST with no statistics will cause the reservoir quota to not be up to date. However, this will only occur for an instance receiving no traffic for 10 seconds and once traffic is received the instance will call GST again within 10 seconds and get the updated quotas.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.