fix(core): address dev server review follow-up#166
Open
snvtac wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #147.
PR #136 left two non-blocking dev-server robustness follow-ups:
npm run devjobs backgrounded from the same shell, letting both proceed as if they were a tsx-watch relaunch;Issue #, if available: #147
Changes
evaluateSingleton()so the same-ppid hot-reload carve-out only proceeds when the recorded owner process is dead; a live same-parent owner that still holds the port now exits like any other competing supervisor.scheduleBindRetry()and wire the EADDRINUSE retry path through a refed timer, removing the retry-timeoutunref().@aws-blocks/core.Validation
npm run build -w packages/hosting -w packages/pipelinenpm run build -w packages/corenode --test dist/scripts/dev-server-reclaim.test.js(38 tests pass)npm run test -w packages/core(582 tests pass)git diff --checknpx biome lint --skip=correctness/noUndeclaredDependencies packages/core/src/scripts/dev-server.ts packages/core/src/scripts/dev-server-reclaim.test.tsnpx tsx scripts/verify-changeset-coverage.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.