Catch MDB_BAD_VALSIZE in LMDBStore.put to prevent unhandled rejections - #654
Open
vzhan00 wants to merge 1 commit into
Open
Catch MDB_BAD_VALSIZE in LMDBStore.put to prevent unhandled rejections#654vzhan00 wants to merge 1 commit into
vzhan00 wants to merge 1 commit into
Conversation
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/vitestThe overall coverage in commit 19f3660 in the Show a code coverage summary of the most impacted files.
Updated |
vzhan00
force-pushed
the
fix/lmdb-bad-valsize-unhandled-rejection
branch
from
July 31, 2026 17:34
5dca91c to
19f3660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LMDBStore.put()now catchesMDB_BAD_VALSIZEerrors and logs + skips the write (returnsfalse) instead of letting the rejection propagate unhandled.Testing
tst/unit/datastore/LMDB.valueSize.test.ts: skip-gracefully onMDB_BAD_VALSIZE, no unhandled rejection, unrelated errors still throw, normal-sized puts unaffected.tst/unit/datastoresuite passes (181 tests).npx eslintclean on both changed files.