fix: delete and recreate stack in ROLLBACK_COMPLETE state#191
Merged
kddejong merged 2 commits intoaws-actions:masterfrom Apr 1, 2026
Merged
fix: delete and recreate stack in ROLLBACK_COMPLETE state#191kddejong merged 2 commits intoaws-actions:masterfrom
kddejong merged 2 commits intoaws-actions:masterfrom
Conversation
…s#107) When a stack is in ROLLBACK_COMPLETE state it cannot be updated. This change detects that state, deletes the stack, and recreates it via a new change set. Closes aws-actions#107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a stack is in
ROLLBACK_COMPLETEstate (e.g., after a failed first deploy), it cannot be updated. The action would fail with an error, requiring manual intervention to delete the stack.Solution
Detect
ROLLBACK_COMPLETEstate indeployStack, automatically delete the stuck stack, wait for deletion to complete, then recreate it via a new change set.Adds a
waitUntilStackDeleteCompletehelper that handles all delete completion scenarios (DELETE_COMPLETE, stack disappears, ValidationError).Testing
Closes #107