Fix focus.global_bydirection not moving focus from empty screen

[JaCoB1123]

When having three monitors and only one client on the first monitor, the function does not work when the middle monitor is focused, as it uses the focused clients' screen instead of the currently focused screen as the base.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.02%. Comparing base (b13ac3e) to head (a9136bc).
⚠️ Report is 136 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3815      +/-   ##
==========================================
+ Coverage   90.99%   91.02%   +0.02%     
==========================================
  Files         900      901       +1     
  Lines       57506    57530      +24     
==========================================
+ Hits        52329    52365      +36     
+ Misses       5177     5165      -12     

Flag	Coverage Δ
gcov	91.02% <100.00%> (+0.02%)	⬆️
luacov	93.71% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
lib/awful/client/focus.lua	92.04% <100.00%> (+0.18%)	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[actionless]

https://github.com/awesomeWM/awesome/actions/runs/5039591637/jobs/9038043696?pr=3815

[JaCoB1123]

The failing assertion seems to concern awful.client.focus.bydirection("right") which I did not modify. No idea how that happened? Also seems to only be the case for lua5.1? Any hints, what I should do?

[actionless]

with 5.2 it's failing as well: https://github.com/awesomeWM/awesome/actions/runs/5039591637/jobs/9038043753?pr=3815

[sclu1034]

Any hints, what I should do?

The first step would be to run the tests locally. make check, IIRC.

[JaCoB1123]

Ok, didn't see that. That error is even weirder though, as it's in line 21 even before calling any of the focus functions.

Any hints, what I should do?

The first step would be to run the tests locally. make check, IIRC.

Thanks for the hint. I unfortunately I have never used lua aside from my awesome config. Therefore I haven't got a local lua dev environment and wasn't able to set one up either because of 'lgi' being missing. I even tried installing lgi by using the steps from the github actions file.

I can't invest more time here, so feel free to close if nobody else is willing to take over.

[Aire-One]

Given this other PR #3817 (that only changes unrelated documentation) has a similar CI fail (the fail is on the same test at least), I guess this is rather an instability in our CI.

[actionless]

indeed it weirdly failed for both of them at the same time - but restarting helped for both