Skip to content

perf: reduce call of has when not necessary #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cesco69 wants to merge 2 commits into from
+5 −5
Closed

perf: reduce call of has when not necessary #388

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8903af
perf: reduce call of has when not necessary
cesco69 Jan 14, 2026
7351603
fix: item
cesco69 Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/lru.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@
* @since 1.0.0
*/
delete (key) {
if (this.has(key)) {
const item = this.items[key];
Comment thread
cesco69 marked this conversation as resolved.
if (item !== undefined) {
const item = this.items[key];

Check failure on line 81 in src/lru.js

View workflow job for this annotation

GitHub Actions / build (24.x) 

'item' is already declared in the upper scope on line 79 column 9

Check failure on line 81 in src/lru.js

View workflow job for this annotation

GitHub Actions / build (22.x) 

'item' is already declared in the upper scope on line 79 column 9

Check failure on line 81 in src/lru.js

View workflow job for this annotation

GitHub Actions / build (20.x) 

'item' is already declared in the upper scope on line 79 column 9

delete this.items[key];
this.size--;
Expand Down Expand Up @@ -176,9 +177,9 @@
*/
expiresAt (key) {
let result;

if (this.has(key)) {
result = this.items[key].expiry;
const item = this.items[key];
if (item !== undefined) {
result = item.expiry;
}

return result;
Expand Down
Loading