registry: allow result_large_err on the axum-idiom error path - #213
Merged
Conversation
clippy 1.98 (current CI stable) grew result_large_err and fires on stream_into's Result<(), Response> - main is red for every PR. The Err IS a full OCI error Response the caller returns verbatim, which is the axum idiom; the fn runs once per upload request, so boxing would trade call-site ergonomics for bytes that do not matter. Targeted allow with the rationale in the doc comment.
There was a problem hiding this comment.
Pull request overview
Adjusts the OCI registry write-path helper to accommodate Rust 1.98 Clippy’s new result_large_err lint without changing the established axum error-handling idiom (returning a full Response to be forwarded verbatim to the client).
Changes:
- Adds a targeted
#[allow(clippy::result_large_err)]onstream_intoto keepResult<(), Response>on the axum-idiom error path. - Documents the rationale inline (avoids boxing/indirection and preserves call-site
?ergonomics on a once-per-request code path).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's stable clippy moved to 1.98 and its new result_large_err lint fires on stream_into's axum-idiom Result<(), Response> — main is red for every open PR (#212 and #183 both fail on it). Targeted allow with rationale; boxing would cost call-site ergonomics on a once-per-request path. Same toolchain-rollover class as avocado-linux/avocadoctl@2b4375f.