release: 0.40.0 — vm download UX, lifecycle-on-CLI, config tree, deploy JSON

.github/workflows/pr.yml

@@ -12,3 +12,23 @@ jobs:
   security:
     name: Security Audit
     uses: ./.github/workflows/security-reusable.yml
+
+  windows-check:
+    name: Windows compile check
+    runs-on: windows-latest
+    steps:
+      - name: Install build pre-reqs
+        run: |
+          choco install nasm cmake -y
+          echo "C:\Program Files\NASM" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          target: x86_64-pc-windows-msvc
+
+      - uses: Swatinem/rust-cache@v2
+
+      - name: cargo check (windows-msvc)
+        run: cargo check --target x86_64-pc-windows-msvc --all-targets

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "avocado-cli"
-version = "0.39.0"
+version = "0.40.0"
 edition = "2021"
 description = "Command line interface for Avocado."
 authors = ["Avocado"]

README.md

@@ -2,7 +2,7 @@
 
 Command line interface for Avocado.
 
-- [Documentation](https://docs.peridio.com/avocado-cli)
+- [Documentation](https://docs.peridio.com/developer-reference/avocado-cli/overview)
 
 ## Install
 

src/commands/build.rs

@@ -545,7 +545,10 @@ impl BuildCommand {
                     merged_value.get("extensions").and_then(|e| e.as_sequence())
                 {
                     for ext in extensions {
-                        if let Some(ext_name) = ext.as_str() {
+                        if let Some(spec) =
+                            crate::utils::runtime_extension::RuntimeExtensionSpec::parse_entry(ext)
+                        {
+                            let ext_name = spec.name.as_str();
                             // Check if this extension has a source: field (remote extension)
                             if let Some(Some(source)) = ext_sources.get(ext_name) {
                                 // Remote extension with source field

src/commands/clean.rs

@@ -185,9 +185,12 @@ impl CleanCommand {
         }
         lock_file.clear_all(&target);
 
-        // Save updated lock file
+        // Save updated lock file. `save_replacing` writes verbatim
+        // without merging from disk — required for unlock semantics
+        // since the regular `save` would re-add the cleared entries
+        // through merge.
         lock_file
-            .save(&src_dir)
+            .save_replacing(&src_dir)
             .with_context(|| "Failed to save lock file")?;
 
         print_success(
@@ -313,6 +316,7 @@ fi
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::utils::lockfile::SysrootType;
     use std::fs;
     use tempfile::TempDir;
 
@@ -381,6 +385,65 @@ mod tests {
         assert!(result.is_ok());
     }
 
+    #[tokio::test]
+    async fn test_clean_unlock_actually_clears_entries() {
+        // Regression: `clean --unlock` must use `save_replacing` so
+        // cleared entries don't get merged back from disk. Previously
+        // it called `save`, which merged with on-disk state and made
+        // unlock a no-op — the desktop app's Unlock button hit this.
+        let temp_dir = TempDir::new().unwrap();
+        let temp_path = temp_dir.path();
+
+        let config_content = r#"
+default_target: "qemux86-64"
+sdk:
+  image: "test-image"
+"#;
+        let config_path = temp_path.join("avocado.yaml");
+        fs::write(&config_path, config_content).unwrap();
+
+        let mut lock = LockFile::new();
+        lock.set_locked_version(
+            "qemux86-64",
+            &SysrootType::Sdk("x86_64".to_string()),
+            "avocado-sdk-bootstrap",
+            "2024.0.129-r0.0",
+        );
+        lock.save(temp_path).unwrap();
+
+        assert!(lock
+            .get_locked_version(
+                "qemux86-64",
+                &SysrootType::Sdk("x86_64".to_string()),
+                "avocado-sdk-bootstrap"
+            )
+            .is_some());
+
+        let clean_cmd = CleanCommand::new(
+            Some(temp_path.to_str().unwrap().to_string()),
+            false,
+            None,
+            false,
+        )
+        .with_config_path(Some(config_path.to_string_lossy().to_string()))
+        .with_target(Some("qemux86-64".to_string()))
+        .with_unlock(true);
+        let result = clean_cmd.execute().await;
+        assert!(result.is_ok(), "clean --unlock failed: {result:?}");
+
+        let reloaded = LockFile::load(temp_path).unwrap();
+        assert!(
+            reloaded
+                .get_locked_version(
+                    "qemux86-64",
+                    &SysrootType::Sdk("x86_64".to_string()),
+                    "avocado-sdk-bootstrap"
+                )
+                .is_none(),
+            "lock entry should be cleared after `clean --unlock`"
+        );
+    }
+
     #[tokio::test]
     async fn test_clean_skip_volumes_keeps_state_file() {
         // `--skip-volumes` means "leave both the volume and its