fix: replace print_and_exit() with Err(anyhow!(...))#123
Merged
mobileoverlord merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
This fixes a deadlock in tui mode, because of tokio task error propagation. Can be reproduced by listing an extension under a runtime, but not defining in the extensions: section. Flow chain before fix: - spawned tokio task (ext build) hits stamp validation failure - calls print_and_exit() → renderer.shutdown() - shutdown() busy-waits with std::thread::sleep(5ms) for the render loop to stop - std::thread::sleep() blocks the tokio thread, preventing the render loop task from running - render loop never sets loop_stopped = true - deadlock — shutdown() spins forever Signed-off-by: Beniamin Sandu <b.sandu@peridio.com>
mobileoverlord
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock in tui mode, because of tokio task error propagation. Can be reproduced by listing an extension under a runtime, but not defining in the extensions: section.
Flow chain before fix: