Open
Conversation
Implements automatic X.509 certificate renewal for IoTConnect Python SDK v2.1. Adds certificate expiry detection, auth challenge, and ACK methods to IoTConnectSDK.py, DER Hex to PEM conversion utilities to util.py, and a firmware callback for certificate rotation in the sample. The implementation is backward compatible and includes error handling and logging for all certificate rotation scenarios.
Refactored IoTConnectSDK to store pending certificate rotation data until the MQTT client is ready, ensuring proper callback execution. Enhanced certificate ACK logic to only send acknowledgments on successful installation. Updated sample firmware to improve certificate conversion, file handling, and output formatting with ANSI colors. Util.py now saves PEM files with explicit encoding and newline handling.
sw-ms-ankitsangani
requested a review
from sw-ms-imranbhadelia
as a code owner
Corrected indentation and comma placement in the SdkOptions dictionary to improve code readability and prevent potential syntax issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.