fix: replace panic with exitError for OS-level failures in mainCmd#48
Closed
jonbaldie wants to merge 1 commit into
Closed
fix: replace panic with exitError for OS-level failures in mainCmd#48jonbaldie wants to merge 1 commit into
jonbaldie wants to merge 1 commit into
Conversation
… main Five panic calls for routine OS errors (MkdirTemp, MkdirAll, CopyFile, RemoveAll, and exec.Run) crashed the tool with a raw stack trace instead of a readable message; they now call exitError or return a non-zero exit code so the user sees what went wrong. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Superseded by #52 which combines this with the exec timeout fix, adds defer for tmpDir cleanup, and resolves the conflict between these two PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five
panic(err)calls for normal OS errors (temp dir creation, mkdir, file copy, RemoveAll, and exec.Run) crashed go-mutesting with a raw stack trace instead of a readable message; they now print the error to stderr and exit cleanly so users know exactly what failed.