fix: unwrap [parsed_page, raw_response] tuple in pagination iterators#738
Open
patrickthornton wants to merge 1 commit into
Open
Conversation
Generated paginated endpoints now return a [parsed_page, raw_response] tuple from the request block (to expose HTTP response metadata), but the iterators in lib/auth0/internal/iterators/ are frozen via .fernignore and were still calling page.send(@item_field) on the raw block result. With a tuple this hits Array#send, surfacing as e.g. `undefined method 'network_acls' for an instance of Array` across all list endpoints. Mirror the fix from the upstream iterator templates: accept either the parsed page directly or a [parsed_page, raw_response] tuple, and use the first element when an Array is returned. Applied to offset_page_iterator.rb (extracted into a private fetch_page helper used at both call sites) and cursor_page_iterator.rb (inline at the single call site). Test results on this branch: 511 runs, 4982 assertions, 0 failures, 0 errors (previously 58 errors, all originating from offset_page_iterator.rb:69 / cursor_page_iterator.rb:46).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.