Skip to content

Moving @types/express to deveDependencies | prod build need not to ha…#447

Closed
nandan-bhat wants to merge 4 commits intomasterfrom
fix/SDK-7266
Closed

Moving @types/express to deveDependencies | prod build need not to ha…#447
nandan-bhat wants to merge 4 commits intomasterfrom
fix/SDK-7266

Conversation

@nandan-bhat
Copy link
Copy Markdown
Contributor

@nandan-bhat nandan-bhat commented Dec 4, 2025

Changes

  • Removed the Express type import from index.d.ts so published typings no longer require Express types.
  • Moved @types/express to devDependencies in package.json, eliminating the transitive @types/mime pull for consumers.

Comment thread package-lock.json
"integrity": "sha512-zXSSClWBPfcSYjg0hcQNompkFN/MxQQ53eyrzm9BYgik2ut2I7PxAf2foVqBRMYCwWaZx/aWodi+uk76npdSAw==",
"dev": true
},
"node_modules/express-jwt-v6/node_modules/jsonwebtoken": {
Copy link
Copy Markdown

@semgrepcode-auth0 semgrepcode-auth0 Bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of jsonwebtoken are vulnerable to Improper Authentication. Insecure implementation of key retrieval function could lead to Forgeable Public/Private Tokens from RSA to HMAC.

Manual Review Advice: A vulnerability from this advisory is reachable if you are using a poorly implemented key retrieval function and your application is supporting usage of both symmetric key and asymmetric key in jwt.verify() implementation with the same key retrieval function.

Fix: Upgrade this library to at least version 9.0.0 at node-jwks-rsa/package-lock.json:2212.

Reference(s): GHSA-hjrf-2m68-5959, CVE-2022-23541

🍰 Fixed in commit efe5321 🍰

Comment thread package-lock.json
"integrity": "sha512-zXSSClWBPfcSYjg0hcQNompkFN/MxQQ53eyrzm9BYgik2ut2I7PxAf2foVqBRMYCwWaZx/aWodi+uk76npdSAw==",
"dev": true
},
"node_modules/express-jwt-v6/node_modules/jsonwebtoken": {
Copy link
Copy Markdown

@semgrepcode-auth0 semgrepcode-auth0 Bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Affected versions of jsonwebtoken are vulnerable to Use Of A Broken Or Risky Cryptographic Algorithm. The library could be misconfigured so that legacy, insecure key types are used for signature verification. For example, DSA keys could be used with the RS256 algorithm.

Manual Review Advice: A vulnerability from this advisory is reachable if you are using a legacy, insecure key type with a supported algorithm; for example, DSA keys could be used with the RS256 algorithm

Fix: Upgrade this library to at least version 9.0.0 at node-jwks-rsa/package-lock.json:2212.

Reference(s): GHSA-8cf7-32gw-wr33, CVE-2022-23539

Fixed in commit efe5321

@nandan-bhat nandan-bhat marked this pull request as ready for review January 9, 2026 05:32
@nandan-bhat nandan-bhat requested a review from a team as a code owner January 9, 2026 05:32
@nandan-bhat nandan-bhat marked this pull request as draft January 9, 2026 05:49
@cschetan77
Copy link
Copy Markdown
Contributor

cschetan77 commented Jan 9, 2026

The build is failing because of higher lockfileVersions generated by npm>=9 are not compatible with lower npms.

@cschetan77
Copy link
Copy Markdown
Contributor

Duplicate of #464

@cschetan77 cschetan77 marked this as a duplicate of #464 Jan 9, 2026
@cschetan77 cschetan77 closed this Jan 9, 2026
@cschetan77 cschetan77 deleted the fix/SDK-7266 branch January 16, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants