Assume multiplying by integer never truncates#706
Open
chiphogg wants to merge 1 commit into
Open
Conversation
This should be true regardless of the rep. After all, integer multiplication is just equivalent to repeated addition. We may overflow, but we could never truncate. To implement this, we do an integer multiplication check at the highest level, even before we split on arithmetic vs. non-arithmetic rep. This will enable a small but meaningful chunk of non-arithmetic rep use cases in a low-risk way. (It's a complete no-op for arithmetic reps.) Helps #122 by unblocking our fix PR.
chiphogg
marked this pull request as ready for review
July 20, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be true regardless of the rep. After all, integer
multiplication is just equivalent to repeated addition. We may
overflow, but we could never truncate.
To implement this, we do an integer multiplication check at the highest
level, even before we split on arithmetic vs. non-arithmetic rep. This
will enable a small but meaningful chunk of non-arithmetic rep use cases
in a low-risk way. (It's a complete no-op for arithmetic reps.)
Helps #122 by unblocking our fix PR.