Skip to content

Add support for rock3b platform#552

Merged
Ivan-Velickovic merged 5 commits intomainfrom
jakub/rock3b
Feb 13, 2026
Merged

Add support for rock3b platform#552
Ivan-Velickovic merged 5 commits intomainfrom
jakub/rock3b

Conversation

@JDuchniewicz
Copy link
Copy Markdown
Contributor

No description provided.

@JDuchniewicz JDuchniewicz requested review from Ivan-Velickovic and removed request for Ivan-Velickovic November 12, 2025 06:42
Copy link
Copy Markdown
Member

@omeh-a omeh-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few minor comments re: timer mostly.

Comment thread drivers/timer/rk3568/timer.c Outdated
Comment thread drivers/timer/rk3568/timer.c Outdated
Comment thread drivers/timer/rk3568/timer.c Outdated
Comment thread drivers/timer/rk3568/timer.c
Comment thread drivers/timer/rk3568/timer.c
Comment thread drivers/timer/rk3568/timer.c
Comment thread drivers/timer/rk3568/timer.c Outdated
Comment thread drivers/timer/rk3568/timer.c Outdated
Comment thread tools/meta/board.py Outdated
@JDuchniewicz JDuchniewicz force-pushed the jakub/rock3b branch 2 times, most recently from 5881734 to 27bc016 Compare November 13, 2025 00:52
@JDuchniewicz
Copy link
Copy Markdown
Contributor Author

The builds will be failing until new version of sdf_gen is released because of adding a parameter to Serial class au-ts/microkit_sdf_gen#27

@JDuchniewicz
Copy link
Copy Markdown
Contributor Author

JDuchniewicz commented Nov 13, 2025

Currently it is broken after 768 seconds due to an overflow in ticks calculation

Copy link
Copy Markdown
Contributor

@midnightveil midnightveil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add this to ci/matrix.py so that CI builds these examples.

Comment thread examples/timer/timer.mk Outdated
Comment thread tools/meta/board.py Outdated
Comment thread drivers/timer/rk3568/timer.c Outdated
@JDuchniewicz
Copy link
Copy Markdown
Contributor Author

Still waiting for a new release of https://github.com/au-ts/microkit_sdf_gen to happen before the CI will be passing. Are we okay with that @Ivan-Velickovic?

@Ivan-Velickovic
Copy link
Copy Markdown
Collaborator

Still waiting for a new release of https://github.com/au-ts/microkit_sdf_gen to happen before the CI will be passing. Are we okay with that @Ivan-Velickovic?

Need to merge some other things for sdfgen, will make a release by the end of the week hopefully.

@JDuchniewicz
Copy link
Copy Markdown
Contributor Author

@midnightveil this depends on seL4/microkit#356 so it won't build right now.

Comment thread ci/matrix.py Outdated
@Ivan-Velickovic
Copy link
Copy Markdown
Collaborator

I started doing the rebase but would be better if the commits were squashed instead.

Something like:

  1. add DTS
  2. add X driver
  3. add Rock3B support to X example

and so on.

@Ivan-Velickovic
Copy link
Copy Markdown
Collaborator

I'll make a separate PR that updates Microkit so then this should just be able to rebase on main and then we can finally merge.

Comment thread drivers/timer/rk3568/timer.c Outdated
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz JDuchniewicz force-pushed the jakub/rock3b branch 3 times, most recently from eee1a69 to fb01cd6 Compare February 13, 2026 03:59
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@Ivan-Velickovic Ivan-Velickovic merged commit 5e17dde into main Feb 13, 2026
14 checks passed
@Ivan-Velickovic Ivan-Velickovic deleted the jakub/rock3b branch February 13, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants