Openterm async on atsamd hal 0 22 on embedded sdmmc#937
Closed
Cooler1989 wants to merge 9 commits intoatsamd-rs:masterfrom
Closed
Openterm async on atsamd hal 0 22 on embedded sdmmc#937Cooler1989 wants to merge 9 commits intoatsamd-rs:masterfrom
Cooler1989 wants to merge 9 commits intoatsamd-rs:masterfrom
Conversation
Update from 0.3 to 0.8 version. Sacrifice delay to embedded sdmmc. Possibly missing SPI interface baud to higher speed after controller initialization.
Contributor
|
Hey @Cooler1989, thanks for this PR, but I don't think it really fits with what we're trying to achieve with BSPs and their examples. The examples are mostly there to showcase the HAL's functionality and how to use its APIs. This doesn't to seem be the case here, it looks more like a full-fledged application with personal project notes and customizations that make the BSP use less general. I'm going to close this for, now but feel free to comment if you feel differently and we can consider reopening the PR if it makes sense. |
Contributor
Author
|
Of course. This is some kind of mistake from my side to push to wrong remote branch. Sorry for the trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[describe your changes here]
Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.If Adding a new Board
crates.jsonIf Adding a new cargo
featureto the HALcrates.jsonNote
The crate changelogs should no longer be manually updated! Changelogs are now automatically generated. Instead: