Skip to content

Openterm async on atsamd hal 0 22 on embedded sdmmc#937

Closed
Cooler1989 wants to merge 9 commits intoatsamd-rs:masterfrom
Cooler1989:openterm_async_on_atsamd_hal_0_22_on_embedded_sdmmc
Closed

Openterm async on atsamd hal 0 22 on embedded sdmmc#937
Cooler1989 wants to merge 9 commits intoatsamd-rs:masterfrom
Cooler1989:openterm_async_on_atsamd_hal_0_22_on_embedded_sdmmc

Conversation

@Cooler1989
Copy link
Copy Markdown
Contributor

Summary

[describe your changes here]

Checklist

  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

Note

The crate changelogs should no longer be manually updated! Changelogs are now automatically generated. Instead:

  • If your PR is contained to a single crate, or a single feature:
    • Nothing else to do; your PR will likely be squashed down to a single commit.
    • Please consider using conventional commmit phrasing in the PR title.
  • If your PR brings in large, sweeping changes across multiple crates:
    • Organize your commits such that each commit only touches a single crate, or a single feature across multiple crates. Please don't create commits that span multiple features over multiple crates.
    • Use conventional commmits for your commit messages.

@jbeaurivage
Copy link
Copy Markdown
Contributor

jbeaurivage commented Jan 25, 2026

Hey @Cooler1989, thanks for this PR, but I don't think it really fits with what we're trying to achieve with BSPs and their examples.

The examples are mostly there to showcase the HAL's functionality and how to use its APIs. This doesn't to seem be the case here, it looks more like a full-fledged application with personal project notes and customizations that make the BSP use less general.

I'm going to close this for, now but feel free to comment if you feel differently and we can consider reopening the PR if it makes sense.

@Cooler1989
Copy link
Copy Markdown
Contributor Author

Of course. This is some kind of mistake from my side to push to wrong remote branch. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants