Ci fix esp32s2 wifi#2382
Open
petermm wants to merge 2 commits into
Open
Conversation
The ESP32 event queue and queue set are process-global, but every test VM initialized them again and overwrote the existing handles. Each invocation leaked both FreeRTOS allocations and gradually exhausted heap on memory-constrained targets. Make queue initialization idempotent and drain retained sender events in the test harness before creating each new GlobalContext. Draining through the queue set prevents stale pointers from a destroyed VM from being delivered to the next one without adding test lifecycle handling to production firmware. Use an explicit void parameter list for the queue initializer declaration and definition. Signed-off-by: Peter M <petermm@gmail.com>
Signed-off-by: Peter M <petermm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP32 CI harness had a leak of the xQueue - LLM estimated close to 0.5kb times 22 leaks for a total of around 10kb leak.
Esp32s2 is under a lot of mem pressure, so lowering
CONFIG_ESP_WIFI_STATIC_RX_BUFFER_NUM=6helps it pass, in future we can enable psram, but seems nice to have a test under some pressure..These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later