Skip to content

Test to illustrate thrown exception (new domain entity) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElGigi wants to merge 10 commits into
base: 0.x
Choose a base branch
from
Open

Test to illustrate thrown exception (new domain entity) #13

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a687b1c
Merge remote-tracking branch 'upstream/0.x' into 0.x
ElGigi Oct 31, 2018
2638c6e
Merge remote-tracking branch 'upstream/0.x' into 0.x
ElGigi Apr 23, 2019
7cb8464
New test to illustrate exception for new domain entity
ElGigi Apr 23, 2019
5457316
Fix thrown exception with no mapped handler during creation of new do…
ElGigi Apr 25, 2019
6bb8e26
Separate/Update test of new entity
ElGigi Apr 30, 2019
90b1e36
Ignore plan if method is null
ElGigi Jan 9, 2020
857c037
Replace deprecated ReflectionParameter::getClass() method
ElGigi Jul 31, 2020
2511a96
Merge branch 'deprecated-reflection' into 0.x
ElGigi Jul 31, 2020
05bcd01
Remove entity from plan if exception is thrown
ElGigi Aug 30, 2022
e6ce034
Fix deprecated creation of dynamic property
ElGigi May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Handler/EntityHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ protected function refreshDomainProperty(
}

// refresh the underlying domain object
$this->handlerLocator->get($datum)->refreshDomain($datum, $refresh);
$handler = $this->handlerLocator->get($datum);
if (!$handler instanceof MappedHandler) {
return;
}
$handler->refreshDomain($datum, $refresh);
}
}
12 changes: 12 additions & 0 deletions tests/ValueObjectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,17 @@ public function test()
];
$actual = $fakeRecord->getArrayCopy();
$this->assertEquals($expect, $actual);


// Test new entity
$newFakeEntity = new Fake(new Email('fake@example.com'),
Copy link
Copy Markdown

@froschdesign froschdesign Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are related to the EntityHandler but this is the test class for a value object. Is this correct?

Copy link
Copy Markdown
Contributor Author

@ElGigi ElGigi Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because it's on the persist of a ValueObject.

Copy link
Copy Markdown

@froschdesign froschdesign Apr 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions for the test:

  1. Create a separate test method and use a name that describes the current testing process.
  2. At the moment the test did not perform any assertions, that should be changed.

Copy link
Copy Markdown
Contributor Author

@ElGigi ElGigi Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;)

new Address('456 Central',
'Bel Air',
'90007',
'CA'),
new DateTime('now'),
new Bag([]));
$this->transit->store($newFakeEntity);
$this->transit->persist();
}
}