Add regression tests for MemoryDenyWriteExecute=true#1071
Merged
Conversation
As reported in #956, executable stacks cause thread creation to fail under MemoryDenyWriteExecute=true. In kernel 6.3+ (which the GitHub Actions runners should have) this is implemented using prctl(PR_SET_MDWE). In older versions systemd uses a more complicated seccomp filter.
Collaborator
Author
|
Fails locally on an existing release, although unfortunately Python's error message is not great: |
jjhelmus
approved these changes
Mar 31, 2026
jjhelmus
reviewed
Apr 16, 2026
| def test_nx_thread_creation(self): | ||
| "Test that thread creation works under e.g. systemd's MemoryDenyWriteExecute." | ||
| # Note that NX cannot be unset so this pollutes the current process, | ||
| # but if something else breaks under NX we probably want to know! |
Contributor
There was a problem hiding this comment.
Is it worth isolating this from other tests via subprocess? Not a blocker to merging.
Collaborator
Author
There was a problem hiding this comment.
Is that easy to do? My gut feeling was the implementation complexity of doing that outweighed the potential benefits (especially since other failures under W^X are probably legitimate bugs) but if there's an easy way to do it I'm fine with it.
jjhelmus
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #956, executable stacks cause thread creation to fail under MemoryDenyWriteExecute=true. In kernel 6.3+ (which the GitHub Actions runners should have) this is implemented using prctl(PR_SET_MDWE). In older versions systemd uses a more complicated seccomp filter.