[UDFS] Fix driver load failure on Windows XP / POSReady 2009#13
Open
Zero3K20 wants to merge 5 commits into
Open
[UDFS] Fix driver load failure on Windows XP / POSReady 2009#13Zero3K20 wants to merge 5 commits into
Zero3K20 wants to merge 5 commits into
Conversation
Simplify APC check to KeGetCurrentIrql() >= APC_LEVEL Co-Authored-By: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
Author
- misc.cpp: Replace KeAreAllApcsDisabled() (WS03SP1+) with KeGetCurrentIrql() >= APC_LEVEL - udfinit.cpp: Make FsRtlRegisterFileSystemFilterCallbacks failure non-fatal - udffs.h: Zero POOL_NX_ALLOCATION (Win8+ flag) in ReactOS compat block Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDFS fails to load on Windows XP because
KeAreAllApcsDisabled(introduced in WS03 SP1) is not exported by XP's ntoskrnl — the PE loader aborts beforeDriverEntryruns.Changes
misc.cpp: ReplaceKeAreAllApcsDisabled()withKeGetCurrentIrql() >= APC_LEVEL— the standard FS driver idiom, available on all NT versions.misc.cpp: FixUDFDestroyZonesto delete all lookaside lists initialized inUDFInitializeZones.UDFNonPagedFcbLookasideList,UDFFcbIndexLookasideList, andUDFFcbDataLookasideListwere leaking on unload.udfinit.cpp: MakeFsRtlRegisterFileSystemFilterCallbacksfailure non-fatal. Driver functions without the pre-acquire section synchronization callback.udffs.h: ZeroPOOL_NX_ALLOCATION(Win8+ flag,0x200) in the__REACTOS__compat block alongside existingNonPagedPoolNx/MdlMappingNoExecutedowngrades. OR-ing it into lookaside list pool types produces an invalid type on XP-era kernels.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.