Add AGENTS.md with fm-shim review guidelines#8
Open
assisted-by-ai wants to merge 1 commit intomasterfrom
Open
Conversation
Captures lessons from PR Kicksecure#358 review feedback to prevent repeating rejected patterns in future contributions. https://claude.ai/code/session_01CgrrFhhVWtqtfhvJdEcBWm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdcapturing lessons from the Improve fm-shim-backend security and D-Bus error handling Kicksecure/security-misc#358 review to prevent repeating rejected patterns in future contributionsGuidelines cover:
close_range()syscall, not/proc/self/fditerationContext
PR Kicksecure#358 was reviewed by ArrayBolt3 who accepted 3 of 5 findings and integrated them into upstream commit
af4f229. This PR only adds theAGENTS.mdfile since the code fixes are already on master.Test plan
AGENTS.mdis present and readablehttps://claude.ai/code/session_01CgrrFhhVWtqtfhvJdEcBWm