Merged
Conversation
|
Contributor
Author
|
Blocked on #776 probably. |
a3cdf70 to
912d5e6
Compare
|
|
5 tasks
arrdem
added a commit
that referenced
this pull request
Mar 4, 2026
The original uv extension prototype treated the uv.lock file as "requirements.txt++" which enormously undersells what uv can and will put into the lockfile. One example of which is that in cases where the user provided marker dependent version constraints, uv will happily solve the constraints for all cases of the markers and generate a lockfile which captures the _version disambiguated_ requirement graph for all configurations, and propagates marker expressions as needed. A related example is that uv retains extras and their activations explicitly as part of the graph rather than simply listing the reach set of requirements after extras have all been activated, which would discard that information. Fixes #798, #797, #794, #792, #791, #773 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes The experimental `uv` extension has seen significant changes to address a number of outstanding bugs. - Multiple versions of a single package are now supported - `[dependency-groups]` are now interpreted as defining build/venv configurations - Extra activations are propagated correctly ### Test plan - New test cases added ### Remaining work - [x] Need to re-validate the Gazelle manifest generation - [x] Need to add a test covering #790 - [x] Need to add a test covering #791 - [x] Need to add a test covering #789 - [x] Need to add a test covering #794 --------- Co-authored-by: aspect-marvin[bot] <marvin@aspect.build>
7a02ba5 to
4243f35
Compare
4243f35 to
7016b8a
Compare
arrdem
pushed a commit
that referenced
this pull request
Mar 7, 2026
Aligns with #773 which establishes "msvc" as the platform_libc value for Windows platforms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e0184ca to
58c6272
Compare
Verifies that packages with no sdist and no Linux wheels don't crash the build graph during analysis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In Bazel 9, sh_test is no longer a native built-in. Add rules_shell as a dependency and load sh_test explicitly.
58c6272 to
4f42bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Packages with only platform-specific wheels (e.g. Windows-only) and no source distribution would crash with an empty
selectchain when built on an incompatible host._no_sbuildfilegroup markedtarget_compatible_with = ["@platforms//:incompatible"]as the default arm when no sdist fallback existswin32,win_amd64, andwin_arm64platform config_settings (withmsvclibc) so Windows wheels are included in the select chain rather than silently droppedis_msvcconfig_setting and makesis_muslvisibility publicThis doesn't enable full Windows builds (no interpreter support yet), but cross-platform lockfiles containing Windows-only packages no longer break analysis on Linux/macOS.
Fixes #754
Test plan
bazel test //...— 87/87 pass//cases/uv-no-sdist-754:test— verifies pywin32 repo has_no_sbuildincompatible default and Windows wheel arms🤖 Generated with Claude Code