fix: read full line for each client message in JavaLoggingClient#555
Open
bmuschko wants to merge 1 commit into
Open
fix: read full line for each client message in JavaLoggingClient#555bmuschko wants to merge 1 commit into
bmuschko wants to merge 1 commit into
Conversation
The interactive loop used Scanner.next() which reads a single whitespace-delimited token, causing multi-word messages after the first to be split into separate sends. Use nextLine() to match the initial read and capture the entire line.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interactive loop in
JavaLoggingClient(logger/client/src/build/aspect/JavaLoggingClient.java) calledscanner.next()on every iteration after the initialscanner.nextLine().Scanner.next()reads only a single whitespace-delimited token, so any message containing a space was split into one send per word. The first message worked correctly because it was read withnextLine(); every subsequent message was tokenized.Switching the in-loop read to
scanner.nextLine()makes the behavior consistent and captures the entire line as a single message.Reproduction
Note the second input
other messagewas sent as two separate messages (other, thenmessage).