refactor(lifecycle): drive tasks through a phases handle - #1373
Draft
jbedard wants to merge 1 commit into
Draft
Conversation
`TaskLifecycleTrait` becomes `Phases`, and a task opens its `_impl` with
`ph = phases.new(ctx, data)` instead of threading `(ctx, lifecycle, data)`
through every call:
setup_phase(ctx, lifecycle, subject, kind, data, hc, bz, cmd)
-> ph.setup(subject, kind, command = cmd)
task_update(ctx, lifecycle, status, progress, ...)
-> ph.update(status, progress, ...)
dispatch_task_update(ctx, lifecycle, update) -> ph.dispatch(update)
apply_repro_fix_hooks(ctx, lifecycle, data, ...)
-> ph.suggest_fixes(kind, status, ...)
The records move behind the same namespace (`phases.Update` /
`.ProgressStyles` / `.Phase` / `.ReproFixCommand`), so `lifecycle.axl` is a
single import at the use site, and a task splats `phases.TRAITS` into its
trait list. `ph.reset(fresh)` refills the held dict in place, which is what
the Bazel retry loop needs between attempts.
`traits.axl` re-exports `Phases` for user config.axl files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskLifecycleTraitbecomesPhases, and a task opens its_implwithph = phases.new(ctx, data)instead of threading(ctx, lifecycle, data)through every call:The records move behind the same namespace (
phases.Update/.ProgressStyles/.Phase/.ReproFixCommand), solifecycle.axlis a single import at the use site, and a task splatsphases.TRAITSinto its trait list.ph.reset(fresh)refills the held dict in place, which is what the Bazel retry loop needs between attempts.traits.axlre-exportsPhasesfor user config.axl files.Changes are visible to end-users: no
Test plan