Emit per-test-target OTel spans with test status in BES tracing sink - #1369
Open
thesayyn wants to merge 2 commits into
Open
Emit per-test-target OTel spans with test status in BES tracing sink#1369thesayyn wants to merge 2 commits into
thesayyn wants to merge 2 commits into
Conversation
The Bazel BES→OTel tracing sink only spanned the `action` events (the TestRunner spawn, which reports the spawn's exit code — 0 for a spawn that merely executed) and dropped `TestSummary`/`TestResult` via the catch-all arm. Failing tests were therefore invisible in OTel: every TestRunner span carried exit_code 0 and no error status. Add dedicated spans: - `test` (from TestSummary): the authoritative per-target outcome, carrying the BlazeTestStatus, run/shard/attempt counts, cached count, real wall-clock timing (first_start_time..last_stop_time), and otel.status_code=error on FAILED/TIMEOUT/FAILED_TO_BUILD/REMOTE_FAILURE/ TOOL_HALTED_BEFORE_TESTING. - `test_attempt` (from TestResult): per shard/run/attempt status + timing. Also set otel.status_code on failed `action` spans, and record every other BES event kind as a lightweight `bes_event` span-event (the high-volume Progress and NamedSetOfFiles streams are intentionally skipped) so no meaningful build event is silently dropped.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b84c5ecae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
✨ Aspect Workflows Tasks📅 Tue Aug 4 21:08:23 UTC 2026 ❌ 4 failed tasks
|
TestSummary/TestResult spans read only the modern `first_start_time`/ `last_stop_time`/`test_attempt_start`/`test_attempt_duration` Timestamp fields, falling back to `SystemTime::now()` (or zero duration) when they were absent. Older Bazel versions and cached summaries populate only the deprecated `*_millis` fields, so those spans were exported at consume time rather than the real test window. Prefer the modern Timestamp, then the deprecated millis field (converted to seconds, matching the OTel layer's `otel.start_time`/`otel.end_time` seconds contract), then `now`/zero as a last resort.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BES→OTel tracing sink only spanned
actionevents (the TestRunner spawn, which reports the spawn's exit code — 0 for a spawn that merely ran) and droppedTestSummary/TestResultvia the catch-all arm. Failing tests were invisible in OTel: every TestRunner span carriedexit_code=0and no error status.Changes (
crates/axl-runtime/src/engine/bazel/sink/tracing.rs):testspan fromTestSummary— the authoritative per-target outcome:status(BlazeTestStatus), run/shard/attempt counts, cached count, real wall-clock timing, andotel.status_code=erroron FAILED/TIMEOUT/FAILED_TO_BUILD/REMOTE_FAILURE/TOOL_HALTED_BEFORE_TESTING.test_attemptspan fromTestResult— per shard/run/attempt status + timing.otel.status_codeon failedactionspans.bes_eventspan-event (high-volumeProgress/NamedSetOfFilesintentionally skipped) so nothing is silently dropped.Unit tests cover the status→span-status mapping.
🤖 Generated with Claude Code
Generated by Claude Code