[codex] Let hide_fields override show_fields#443
Draft
xantrac wants to merge 1 commit into
Draft
Conversation
533623d to
6230e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns
show_fieldswith the mergedhide_fieldsruntime visibility implementation from #442.show_fieldsandhide_fields.show_field?/2precedence wherehide_fieldswins.show_fields.Validation
Passed with local available toolchain
ASDF_ELIXIR_VERSION=1.19.0-otp-28 ASDF_ERLANG_VERSION=28.1:mix spark.formattermix format --check-formattedmix compile --warnings-as-errorsmix test test/acceptance/field_visibility_test.exsmix test test/acceptance/open_api_test.exsmix test test/acceptance/json_schema_test.exsmix test test/acceptance/get_test.exs test/acceptance/index_test.exs test/acceptance/get_related_test.exs test/spec_compliance/fetching_data/inclusion_of_related_resources_test.exsmix docsFull
mix testwas also run, but it currently fails in existing pagination tests with a Xema/Regex exported pattern error under the local Elixir/Erlang versions. The repository-pinned patch versions were not installed locally.